Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memo integrity check in validity predicates #3960

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Memo integrity check in validity predicates #3960

merged 8 commits into from
Nov 21, 2024

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Oct 29, 2024 •
edited
Loading

Describe your changes

Extended the VerifySigGadget to also check the integrity of the memo section (if present). Added wasm tests to cover this scenario.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.47826% with 19 lines in your changes missing coverage. Please review.

Project coverage is 74.58%. Comparing base (48f3ccd) to head (9171b37).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
wasm/vp_implicit/src/lib.rs 72.97% 10 Missing ⚠️
wasm/vp_user/src/lib.rs 76.31% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3960      +/-   ##
==========================================
+ Coverage   74.55%   74.58%   +0.02%     
==========================================
  Files         341      341              
  Lines      107399   107484      +85     
==========================================
+ Hits        80073    80165      +92     
+ Misses      27326    27319       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@grarco grarco requested a review from tzemanovic November 20, 2024 17:23
grarco added a commit that referenced this pull request Nov 21, 2024
@grarco
Changelog #3960
b856a8c
@grarco grarco added this to the v0.46.0 milestone Nov 21, 2024
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Nov 21, 2024
@grarco grarco added bug Something isn't working validity-predicate security labels Nov 21, 2024
@grarco grarco changed the title WIP memo check Memo integrity check in validity predicates Nov 21, 2024
mergify bot added a commit that referenced this pull request Nov 21, 2024
@mergify
Merge of #3960
fa27ece
@mergify mergify bot mentioned this pull request Nov 21, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

Hey @grarco, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@tzemanovic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify bot added a commit that referenced this pull request Nov 21, 2024
@mergify
Merge of #3960
097d5a0
@mergify mergify bot mentioned this pull request Nov 21, 2024
Closed
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

Hey @grarco, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@grarco grarco force-pushed the grarco/memo-validation-in-vp branch from b856a8c to 73898d6 Compare November 21, 2024 11:57
@grarco
Copy link
Collaborator Author

grarco commented Nov 21, 2024

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@mergify mergify bot merged commit 06e02de into main Nov 21, 2024
24 checks passed
@mergify mergify bot deleted the grarco/memo-validation-in-vp branch November 21, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic tzemanovic approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass security validity-predicate
Projects
None yet
Milestone
v0.46.0
Development

Successfully merging this pull request may close these issues.
2 participants
@grarco @tzemanovic